8000 Split the long Rust tests of queries and jetdb-wasm into smaller ones by dominion525 · Pull Request #128 · dominion525/jetdb · GitHub
[go: up one dir, main page]
Skip to content
8000

Split the long Rust tests of queries and jetdb-wasm into smaller ones - #128

Merged
dominion525 merged 2 commits into
mainfrom
test/split-long-rust-tests
Oct 24, 2026
Merged

Split the long Rust tests of queries and jetdb-wasm into smaller ones#128
dominion525 merged 2 commits into
mainfrom
test/split-long-rust-tests

Conversation

@dominion525
@dominion525 dominion525 commented Oct 24, 2026
Copy link
Copy Markdown
Owner

Summary

  • Four tests of query.rs and two of jetdb-wasm were above the complexity thresholds of scripts/quality-check.sh (CC ≥ 10, cognitive ≥ 10 or SLOC ≥ 50), and none of them is now.
  • The four tests of query.rs had the same match of nine arms, from the name of each test query to its type. The names and types are now a table, QUERY_TEST_TYPES, checked by one function.
  • The two tests of jetdb-wasm have their comparisons moved into functions, and the test of form properties is split into three: the numbers and names, the values of a form, and the values of a report.
  • What the tests check is unchanged.
  • Functions above the thresholds: 144 → 138. Tests: 1085 → 1087.
Test Before (CC / Cog / SLOC) After, the largest function Tests
query read_queries_types 12 / 3 / 20 4 / 1 / 9 1
query read_queries_jet3 13 / 3 / 28 2 / 0 / 14 1
query read_queries_ace14 13 / 3 / 28 2 / 0 / 14 1
query read_queries_v2007 12 / 3 / 25 1 / 0 / 11 1
jetdb-wasm macros_as_jetdb_macro_shows_them 6 / 7 / 72 2 / 1 / 24 1
jetdb-wasm form_properties_as_jetdb_form_props_shows_them 11 / 3 / 81 3 / 3 / 30 3

🤖 Generated with Claude Code

dominion525 and others added 2 commits October 25, 2026 03:17
@dominion525 @claude
Write the types of the test queries of query.rs once, rather than as …
b089e40 
…the same match in four tests

- Put the names and types of the queries in a table, QUERY_TEST_TYPES, checked by one function
- Have the four tests call that function

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@dominion525 @claude
Split the long tests of jetdb-wasm by what each of them compares, to …
5e64e14 
…make them easier to read

- Make the comparisons of named, embedded and data macros, and the check of the errors for names that are not there, functions
- Split the test of form properties into three, of the numbers and names, of the values of a form and of the values of a report, with the lists of names made by functions

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions
github-actions Bot commented Oct 24, 2026
Copy link
Copy Markdown

Coverage

For 5e64e14.

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
jetdb-cli/src/export.rs            108                11    89.81%           5                 0   100.00%          66                 6    90.91%           0                 0         -
jetdb-cli/src/form.rs              254                24    90.55%          19                 5    73.68%         152                 9    94.08%           0                 0         -
jetdb-cli/src/macro_cmd.rs         151                11    92.72%          11                 2    81.82%          81                 5    93.83%           0                 0         -
jetdb-cli/src/main.rs              864                38    95.60%          70                 2    97.14%         549                25    95.45%           0                 0         -
jetdb-cli/src/prop.rs              308                15    95.13%          33                 2    93.94%         186                10    94.62%           0                 0         -
jetdb-cli/src/query.rs              80                 4    95.00%           5                 0   100.00%          51                 1    98.04%           0                 0         -
jetdb-cli/src/vba.rs                74                 4    94.59%           5                 0   100.00%          47                 1    97.87%           0                 0         -
jetdb-wasm/src/lib.rs             3871                95    97.55%         252                 4    98.41%        2031                22    98.92%           0                 0         -
jetdb/src/catalog.rs               531                14    97.36%          41                 0   100.00%         304                 7    97.70%           0                 0         -
jetdb/src/complex.rs               917                32    96.51%          73                 0   100.00%         607                15    97.53%           0                 0         -
jetdb/src/crypto.rs               2284               210    90.81%         105                21    80.00%        1301               169    87.01%           0                 0         -
jetdb/src/csv.rs                   810                23    97.16%          65                 0   100.00%         453                 6    98.68%           0                 0         -
jetdb/src/data.rs                 4523               176    96.11%         246                 2    99.19%        2509               109    95.66%           0                 0         -
jetdb/src/ddl/access.rs             70                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/mod.rs              2777                 8    99.71%         199                 2    98.99%        1510                 6    99.60%           0                 0         -
jetdb/src/ddl/mysql.rs              70                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/postgres.rs           71                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/sqlite.rs             69                 0   100.00%           7                 0   100.00%          48                 0   100.00%           0                 0         -
jetdb/src/encoding.rs              284                 0   100.00%          30                 0   100.00%         153                 0   100.00%           0                 0         -
jetdb/src/file.rs                 1947                67    96.56%         107                 0   100.00%        1021                26    97.45%           0                 0         -
jetdb/src/form.rs                 3253               150    95.39%         227                10    95.59%        1775                69    96.11%           0                 0         -
jetdb/src/form2000.rs              762                21    97.24%          56                 1    98.21%         402                 4    99.00%           0                 0         -
jetdb/src/format.rs                620                 2    99.68%          41                 0   100.00%         408                 2    99.51%           0                 0         -
jetdb/src/lib.rs                     3                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
jetdb/src/macro_action.rs          299                19    93.65%          27                 3    88.89%         163                24    85.28%           0                 0         -
jetdb/src/macro_def.rs            2280                98    95.70%         171                 9    94.74%        1517                46    9
8000
6.97%           0                 0         -
jetdb/src/macro_text.rs            756                24    96.83%          47                 2    95.74%         426                20    95.31%           0                 0         -
jetdb/src/map.rs                   416                13    96.88%          27                 0   100.00%         221                 5    97.74%           0                 0         -
jetdb/src/money.rs                 286                 0   100.00%          26                 0   100.00%         189                 0   100.00%           0                 0         -
jetdb/src/prop.rs                 1413                55    96.11%          88                 8    90.91%         746                63    91.55%           0                 0         -
jetdb/src/query.rs                2625                71    97.30%         187                 1    99.47%        1644                35    97.87%           0                 0         -
jetdb/src/relationship.rs          302                27    91.06%          12                 0   100.00%         187                17    90.91%           0                 0         -
jetdb/src/save_as_text.rs          574                27    95.30%          52                 3    94.23%         341                27    92.08%           0                 0         -
jetdb/src/storage.rs               571                46    91.94%          23                 1    95.65%         318                24    92.45%           0                 0         -
jetdb/src/table.rs                1594                65    95.92%          94                 2    97.87%         948                21    97.78%           0                 0         -
jetdb/src/timestamp.rs             413                 0   100.00%          43                 0   100.00%         232                 0   100.00%           0                 0         -
jetdb/src/vba.rs                   634                65    89.75%          54                16    70.37%         361                60    83.38%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            36864              1415    96.16%        2470                96    96.11%       21088               834    96.05%           0                 0         -

@dominion525
dominion525 merged commit 9e8ad45 into main Oct 24, 2026
11 checks passed
@dominion525
dominion525 deleted the test/split-long-rust-tests branch October 24, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dominion525
0