Repository navigation
Make the columns Access requires a value in NOT NULL in the schema and DDL - #100
Merged
Merged
Conversation
…d DDL - Access keeps the NULLABLE flag on every column and stores "Required" as the Required property of the column, so the schema and DDL never wrote NOT NULL but for AutoNumber columns - Clear NULLABLE in schema_tables on each column whose Required property is Yes, so that jetdb schema, jetdb schema --ddl and ddl in jetdb-wasm write NOT NULL for it - Add a test that the DDL of jetdb-sample.accdb has NOT NULL on its required columns alone Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- Say in docs/cli.md and docs/cli.ja.md that a column whose Required property is Yes, and an AutoNumber column, is NOT NULL in the DDL and in the column list of jetdb schema Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… complexity threshold - Move the check whether a map of properties is that of a column whose Required property is Yes into is_required, and let clear_nullable_of_required collect the names of those columns and clear their flags, which takes its cyclomatic complexity from 10 to 7 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOT NULLfrom theNULLABLEflag of each column, but Access keeps that flag on every column: none of the 2,430 columns of the test databases is without it. "Required" in the table design of Access is theRequiredproperty of the column, which 106 of them have set. Sojetdb schema,jetdb schema --ddlandddlin jetdb-wasm wroteNOT NULLfor AutoNumber columns alone.ddl::schema_tables, which the three use, now clearsNULLABLEon each column whoseRequiredproperty is Yes, as it already gives each calculated column the type of its result. Injetdb-sample.accdb, the four required columns oftblOrdersareNOT NULLnow.jetdb-sample.accdbhasNOT NULLon its six required columns and three AutoNumber columns alone.docs/cli.md/docs/cli.ja.mdsay which columns areNOT NULL.🤖 Generated with Claude Code