8000 Fail on warnings of cargo doc, after fixing the five it gave by dominion525 · Pull Request #106 · dominion525/jetdb · GitHub
[go: up one dir, main page]

Skip to content

Fail on warnings of cargo doc, after fixing the five it gave - #106

Merged
dominion525 merged 2 commits into
mainfrom
fix/doc-warnings
Oct 21, 2026
Merged

dominion525 merged 2 commits into
mainfrom
fix/doc-warnings

Conversation

@dominion525
Copy link
Copy Markdown
Owner

Summary

  • Drop the links from public documentation to private items, which cargo doc warned of: in jetdb, from read_table_rows to read_calculated_value and from form2000 to VERSION, written now as the byte 0x13, and in jetdb-wasm, from the types to type_name, query_type_name and module_type_name
  • Set RUSTDOCFLAGS="-D warnings" for the doc step of quality-check.sh and of CI, which did not fail on warnings, so that they no longer pile up unnoticed, and tell it in docs/ci (en/ja)

🤖 Generated with Claude Code

dominion525 and others added 2 commits October 21, 2026 12:59
…o doc warned of

- In jetdb, the documentation of read_table_rows linked to read_calculated_value and that of form2000 to VERSION, and in jetdb-wasm, that of the types to type_name, query_type_name and module_type_name
- Write them as code without links, and the version byte of form2000 as 0x13

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- Warnings did not fail them, so links from public documentation to private items piled up unnoticed
- Set RUSTDOCFLAGS="-D warnings" for the doc step of quality-check.sh and of CI, and tell it in docs/ci (en/ja)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@dominion525
dominion525 merged commit 10ddf9f into main Oct 21, 2026
10 checks passed
@dominion525
dominion525 deleted the fix/doc-warnings branch October 21, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0