Repository navigation
Give the fallback names of control types and the { name, type } objects one place each - #105
Merged
Merged
Conversation
…does not know, from the library - The CLI's form controls and form props, jetdb-wasm and its tests wrote the same fallback in five places - Add control_type_label to the library, as BlobProperty::display_name gives a property, and use it in all five; the output stays the same Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- queries, modules and forms wrote the same code for the object of each query, module, and form or report - Add name_and_type to js.rs and use it in all three, keeping the Rust structs Query, Module and Form, whose types hold different kinds of values; the output stays the same Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x....for one jetdb does not know, as BlobProperty::display_name gives a property. The CLI's form controls and form props, jetdb-wasm and its tests use it instead of each writing the same fallback{ name, type }objects ofqueries,modulesandformsin jetdb-wasm with one function, name_and_type, keeping the Rust structs Query, Module and Form, whose types hold different kinds of values🤖 Generated with Claude Code