Repository navigation
Add smoke-test-derived notes (fill, AGENTS) - #8
Merged
Merged
Conversation
Real-Chrome smoke test of the PR #6 changes surfaced that filling an <input> with a multi-line value loses the LFs — not a familiar bug, the HTML spec strips LF from <input> value (single-line by design). textarea retains LF correctly. Add a one-line note to: - mcp/src/tools.ts familiar_fill description - skills/familiar/reference-actions.md fill entry - skills/familiar/reference-actions.ja.md fill entry so an LLM reading the schema or a human reading the reference is told to switch to <textarea> when newlines matter. jsEscape itself is unaffected (it still escapes LF / CR / Tab so the value survives AppleScript's JS literal embedding) — the LF drop is purely at the input element layer in the browser.
While smoke-testing the MCP server, found that pages served via `data:` URLs do not execute inline `<script>` blocks or `` event handlers under Chrome's data-URL security restrictions. Document this in AGENTS.md / AGENTS.ja.md's "Development and verification" section so future smoke tests assert against DOM state the action itself writes (e.g. `set_checked` → `el.checked`) rather than inline-JS side effects that won't run. For inline script execution, serve from `file://` or a local http server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small documentation notes surfaced while smoke-testing the PR #6 changes against a real Chrome.
0cdb537 — Note input strips LF in fill description (HTML spec)
mcp/src/tools.ts) andreference-actions.md/.ja.mdgain a one-liner:<input>strips LF per HTML spec, use<textarea>if newlines must be preservedba62bd0 — Note data URL inline script restriction in AGENTS for smoke testing
AGENTS.md/AGENTS.ja.md's "Development and verification" section gains a one-liner: pages served viadata:URLs do NOT execute inline<script>orunder Chrome's data-URL security restrictionsfile://or a local http server if inline script execution is neededBoth are docs-only, no functional change. Companion of the real-Chrome smoke test of PR #6 changes (all 32 tools verified working).