Repository navigation
Cover the About icon and the display changes - #15
Merged
Merged
Conversation
- Test makeAboutIcon throu 8B8E gh the bundle it already takes for the purpose: both drawings, either one missing, and neither - Test what a display change does, both when the displays did not move and when the frames no longer line up, and that the effect stays on screen through one Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeAboutIconthrough the bundle parameter it already takes for the purpose, which nothing was using: both drawings present, either one missing, and neitherThese were the two places where coverage could be raised without reaching for something the tests cannot touch. Blip.app goes from 83.99% to 86.93% (771/918 to 798/918), all of it in main.swift.
What remains uncovered is uncovered for a reason: creating a real event tap needs the Input Monitoring permission and a run loop,
restart()would end the test runner, the About and Settings windows and System Settings would open,checkForUpdates()reaches the network, andMainAppLoginItemwould register a real login item. The protocol it conforms to exists so tests use a fake instead.🤖 Generated with Claude Code