8000 [BUG] Resolve Files and DBFS paths to UC volume storage by eddiethedean · Pull Request #72 · dmux/minilake · GitHub
[go: up one dir, main page]
Skip to content

[BUG] Resolve Files and DBFS paths to UC volume storage - #72

Merged
dmux merged 7 commits into
dmux:mainfrom
eddiethedean:codex/fix-files-volume-path-38
Oct 27, 2026
Merged

[BUG] Resolve Files and DBFS paths to UC volume storage#72
dmux merged 7 commits into
dmux:mainfrom
eddiethedean:codex/fix-files-volume-path-38

Conversation

@eddiethedean
@eddiethedean eddiethedean commented Oct 26, 2026 •
edited
Loading
Copy link
Copy Markdown
Collaborator

Summary

  • Route /Volumes/<catalog>/<schema>/<volume>/... paths from both Files and DBFS into the Unity Catalog volume directory.
  • On first startup after upgrade, migrate existing volume files from the old dbfs/Volumes tree into their UC volume directories.
  • Persist completion of that migration so files from volumes deleted before the upgrade cannot be imported into volumes created later.
  • Preflight migrations and stop with the conflicting path rather than overwrite either copy.
  • Reject malformed, missing-volume, and escaping paths while keeping ordinary Files and DBFS paths on their existing shared root.
  • Add restart regressions for preserving active-volume files and preventing deleted-volume files from returning after recreation.

Fixes #38.

Validation

  • Ruff lint and formatting checks passed.
  • Focused Docker SDK restart tests passed.
  • Full CI passed: lint, Docker test suite, and UI checks.

@eddiethedean
Fix Files and DBFS paths for UC volumes
66ca867
@eddiethedean
Migrate existing Files data into UC volumes
b87c668
@eddiethedean
test(volumes): cover legacy data migration on restart
499ebc2
@eddiethedean
fix(volumes): avoid reviving deleted volume files
579c218
@eddiethedean
fix(volumes): make legacy migration one-time
8561588
@eddiethedean
eddiethedean commented Oct 26, 2026
Copy link
Copy Markdown
Collaborator Author

Ready to merge.

Reviewed the full PR at commit 8561588e23adb97eed5a6bb00fdf04dd6413ede4; no remaining high or critical findings. Verified a real upgrade followed by repeated restarts: active volume files survive, recreated volumes retain their new content, and deleted legacy files remain unavailable.

All CI checks pass: lint, Docker test suite, and UI.

@dmux
dmux merged commit 44ec8a6 into dmux:main Oct 27, 2026
3 checks passed
@dmux dmux self-assigned this Oct 27, 2026
@dmux dmux added the bug Something isn't working label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dmux dmux

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Files API stores volume content outside the Unity Catalog volume directory

2 participants

@eddiethedean @dmux
0