Repository navigation
[BUG] Clear default DuckDB data on full reset - #71
Merged
Merged
Conversation
Collaborator
Author
|
Ready to merge. Reviewed the full PR at eb1b5a0 with no high or critical findings. All CI checks passed: lint, UI, and tests. The 7 admin/persistence tests passed, and additional Docker checks verified repeated full resets, catalog recreation, SQL reuse, and Delta extension reload. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unity_catalog.duckdbdatabase and its WAL duringfull=trueresets, after service reset hooks detach catalog connections.Fixes #39.
Validation
docker compose -f docker-compose.test.yml run --rm test-runner pytest tests/test_admin.py tests/test_persistence.py -v --tb=short— 7 passed.