8000 [BUG] Reject invalid job dependency graphs by eddiethedean · Pull Request #70 · dmux/minilake · GitHub
[go: up one dir, main page]

Skip to content

[BUG] Reject invalid job dependency graphs - #70

Merged
dmux merged 2 commits into
dmux:mainfrom
eddiethedean:fix/job-dependency-validation-40
Oct 28, 2026
Merged

dmux merged 2 commits into
dmux:mainfrom
eddiethedean:fix/job-dependency-validation-40

Conversation

@eddiethedean
Copy link
Copy Markdown
Collaborator

Summary

  • Reject duplicate task keys, unknown dependencies, and cyclic dependency graphs when creating, updating, resetting, or submitting jobs.
  • Validate updates before replacing stored settings, and fail runs that encounter invalid graphs in restored state.
  • Add SDK regression coverage for malformed graphs and verify valid DAG scheduling still works.

Closes #40

Validation

  • Dockerized Jobs API regression and DAG tests: 8 passed.
  • Ruff check, formatting check, and git diff --check passed.

@eddiethedean
Copy link
Copy Markdown
Collaborator Author

This PR is ready to merge. Review of commit 1921949 found no high or critical defects. All CI checks passed, including lint, UI, and the full Docker suite (411 tests passed). Additional isolated Docker checks covered 512 dependency graphs, duplicate references, a 2,500-task chain, and invalid runtime/legacy graphs, confirming that invalid workflows execute no tasks.

@dmux dmux self-assigned this Oct 28, 2026
@dmux dmux added the bug Something isn't working label Oct 28, 2026
@dmux
dmux merged commit 90f86b8 into dmux:main Oct 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Invalid job dependencies execute tasks or report successful cycles

2 participants

0