Repository navigation
[BUG] Preserve newest results when the SQL statement cache overflows - #67
Merged
dmux merged 2 commits intoOct 28, 2026
Merged
Conversation
Collaborator
Author
|
This PR is ready to merge. Review of commit 309c8bd found no high or critical defects. All CI checks passed, including lint, UI, and the Docker test suite (407 tests passed), including the cache-overflow regression. Additional isolated checks confirmed that repeated overflow and failed statements preserve retained results across cache boundary values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
Statement cache overflow cleared result rows while checking whether the cache was still over its limit. Because clearing rows did not reduce the statement count, a single overflow cleared every cached result, including the newest one. The cache now removes only the oldest excess statement entries and preserves results for the statements it retains.
The SDK regression test crosses the cache boundary and repeats overflow, fetching the newest external result at the limit, limit + 1, and limit + 2.
Validation: Ruff lint, Ruff format check, and
git diff --checkpassed. GitHub CI will run the Docker test suite.