8000 [BUG] Honor idempotency tokens for jobs/run-now by eddiethedean · Pull Request #64 · dmux/minilake · GitHub
[go: up one dir, main page]

Skip to content

[BUG] Honor idempotency tokens for jobs/run-now - #64

Merged
dmux merged 4 commits into
dmux:mainfrom
eddiethedean:fix/run-now-idempotency-56
Oct 28, 2026
Merged

dmux merged 4 commits into
dmux:mainfrom
eddiethedean:fix/run-now-idempotency-56

Conversation

@eddiethedean
@eddiethedean eddiethedean commented Oct 25, 2026 •
Copy link
Copy Markdown
Collaborator

Closes #56

jobs/run-now accepted idempotency_token as an extra request field but ignored it, so retries launched duplicate job runs and repeated side effects. This change validates the 64-character token limit, records token-to-run mappings in persisted job state, and returns the original run for retries. Reusing a token after its run has been deleted returns an error, matching the Databricks API contract.

Persisted snapshots encode numeric registry keys as JSON strings. Restore now converts job, run, and task-output keys back to integers so run lookups and idempotency retries keep working after restart.

Validation: Docker persistence restart regression passed; Ruff lint, format, and git diff --check passed. GitHub CI is running on this update.

@eddiethedean
Copy link
Copy Markdown
Collaborator Author

This PR is ready to merge. The full review is complete, and all CI checks have passed.

@dmux dmux self-assigned this Oct 28, 2026
@dmux dmux added the bug Something isn't working label Oct 28, 2026
@dmux
dmux merged commit 94dccb8 into dmux:main Oct 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] jobs/run-now ignores idempotency_token and executes duplicate writes on retry

2 participants

0