Repository navigation
fix(packaging): keep the web UI in the sdist, so the wheel keeps it too - #5
Merged
Merged
Conversation
`uv build` — what the release workflow runs — builds the sdist first and then builds the wheel *from that sdist*. The `artifacts` override that rescues the gitignored `ui_static` export was declared only on the wheel target, so the export was dropped at the sdist step and the published wheel had no web UI at all. Nothing fails when this happens: the wheel installs and runs, there is just no /ui. It went unnoticed because `uv build --wheel` builds straight from the source tree and does include it, and because 1.6.0 shipped before the UI existed. Adds the same override to the sdist target, plus a release-workflow step that fails the publish if the wheel arrives without the UI — a PyPI upload cannot be replaced.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while pre-flighting the 1.7.0 release.
uv build— whatrelease.ymlruns — builds the sdist first, then builds the wheel from that sdist. Theartifactsoverride that rescues the gitignoredsrc/minilake/ui_staticexport was only on the wheel target, so the export was dropped at the sdist step and the wheel came out empty:ui_staticfiles in wheeluv build --wheel(straight from the tree)uv build(sdist → wheel, as in CI)Nothing fails when this happens — the wheel installs and runs, it just has no
/ui. And a PyPI upload cannot be replaced. It went unnoticed because 1.6.0 shipped before the UI existed.Changes
artifactsoverride on the sdist target. Verified: 265 files now survive sdist → wheel.release.ymlthat fails the publish if the wheel arrives without the UI, so this cannot regress silently.Blocks tagging v1.7.0.