Repository navigation
fix(scripts): call dlt's workspace_deps() instead of parsing WORKSPACE_DEPS - #44
Merged
Merged
Conversation
…E_DEPS dlt 1.32.0 replaced the literal with a computed function. Run it via `uv run --isolated --with dlt==<locked>`; fall back to the constant for older dlt. Closes #43
burnash
force-pushed
the
fix/sync-workspace-deps-callable
branch
from
November 5, 2026 13:57
1f51ab3 to
dfdc25e
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Tests mock both dlt and subprocess, leaving real import-time dependencies and compatibility unverified until smoke checks against dlt 1.31.0 and 1.32.0 can run in an environment that supports installing them.
No open issues 🎉
What changed in this PR
Updates scaffold dependency syncing for dlt 1.32.0’s computed workspace_deps() API, addressing #43 while retaining compatibility with older dlt versions.
Changes:
- Replaces wheel parsing with an isolated
uvprobe using the scaffold’s locked dlt version, with a fallback toWORKSPACE_DEPS. - Adds unit tests for the probe, output validation, and subprocess failures.
- Updates documentation, workflow labels, and generated messages to use the new API name.
| File | Description |
|---|---|
tests/test_scripts.py |
Tests callable probing, legacy fallback, parsing, and execution errors. |
scripts/sync_workspace_deps.py |
Replaces wheel parsing with an isolated runtime probe. |
Makefile |
Updates dependency-sync target descriptions. |
CONTRIBUTING.md |
Updates dependency-sync guidance for the callable API. |
CHANGELOG.md |
Records the dlt 1.32.0 compatibility fix. |
.github/workflows/ci.yml |
Updates the dependency-check step label. |
.github/workflows/bump-dlthub-init.yml |
Updates comments, messages, and generated acceptance criteria. |
.github/workflows/bump-changelog-entry.cjs |
Uses the callable name in generated changelog entries. |
Review effort: Balanced
anuunchin
reviewed
Nov 5, 2026
burnash
force-pushed
the
fix/sync-workspace-deps-callable
branch
from
November 5, 2026 16:17
90ead1c to
8569387
Compare
8000
anuunchin
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
dlt 1.32.0 turned
< 8000 h2 dir="auto">ChangesWORKSPACE_DEPSinto a computedworkspace_deps(), so the sync script could not read it from the wheel. Resolves #43.uv run --isolated --with dlt==<locked>and callsworkspace_deps(). Falls back to the constant for older dlt.WORKSPACE_DEPSwording updated in Makefile, workflows, CONTRIBUTING.Tests
uvfailures.