Repository navigation
Decode unknown channel, overwrite, webhook, integration and command types instead of failing - #644
Merged
Merged
Conversation
…ypes instead of failing
…ng, table-drive round-trip tests
Contributor
Author
|
Maybe the gateway code should generally not reconnect on a decode error 🤔 |
|
Omg so that's what has been killing my gateway 😭 |
|
Like I suspect many others, my bot is down awaiting a fix. |
Member
|
lol yeah, that's a fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding a channel, permission overwrite, webhook, integration, application command, command option or command permission with a type disgo doesn't know now returns an
Unknown*value, the same wayUnknownComponentworks, instead of an error.On Nov 5 Discord started sending channels with type 20 in
GUILD_CREATE.UnmarshalChannelerrored and failed the whole dispatch. The gateway treats that as a read error and resumes, Discord replays the same event, and the shard loops until the token is reset.This doesn't change how the gateway handles a dispatch that fails to decode. Any other parse error still causes the same reconnect loop.