Repository navigation
chore: satisfy gofumpt on master - #597
Closed
phpboyscout wants to merge 1 commit into
Closed
phpboyscout wants to merge 1 commit into
phpboyscout wants to merge 1 commit into
Conversation
golangci-lint 2.13.1 bundles a gofumpt that removes redundant parentheses around a conversion's type — (T)(x) becomes T(x). Four linted files carry the older form, so `golangci-lint run` fails on master and therefore on every pull request opened against it. Formatting only. No behaviour, no exported surface, no test changes. _examples is left alone; the lint configuration excludes it, and touching it would make this diff larger than the thing it fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint runcurrently fails onmaster, so every pull request opened against it inherits a red check that has nothing to do with the change.golangci-lint 2.13.1 bundles a gofumpt that removes redundant parentheses around a conversion's type —
(T)(x)becomesT(x). Four linted files carry the older form:discord/access_token.godiscord/activity.gogateway/gateway_events.govoice/udp_conn.goFormatting only — no behaviour, no exported surface, no test changes.
go build ./...andgo test ./...unchanged._examplesis left alone: the lint configuration excludes it, and including it would make the diff several times larger than the thing it fixes.Noticed while #596's check went red. That PR touches
voice/udp_conn.go, so whichever of the two merges second will need a trivial rebase — happy to sequence them whichever way suits you, or to fold this into #596 if you would rather not carry a separate formatting commit.