Repository navigation
Conversation
Type 21 stores the tempo in the whole value. The first byte alone is 0 for every tempo below 256.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112.
The
tmpoatom is type 21. iTunes stores the tempo as a big-endian integer whose width is the value length, usually two bytes.readAtomDatakept only the first byte, so a tempo below 256 was stored as 0 and 300 was stored as 1.TestMP4TempoReadsBigEndianIntegerreads 120 (00 78) and 300 (01 2c). Without thetmpobranch those values come back as 0 and 1.Other type 21 atoms still use the first byte.
cpilis one byte, and widening everyuint8value would turn a padded flag into a larger integer.