Repository navigation
Tags
Tags
windows: fix memory corruption when closing shared server sockets
build: rework -fvisibility=hidden detection Make the gcc_version macro conform with what node.js and v8 use. Important because node.js's common.gypi is going to export it soon.
windows: map WSANO_DATA to UV_ENOENT This improves uv_getaddrinfo error reporting.
windows: invalid stdio handles should be INVALID_HANDLE_VALUE and not… … NULL
sunos: workaround OS bug to prevent fs.watch() from spinning This is a back-port of commit cfb06db from the master branch. Fixes nodejs/node-v0.x-archive#3768.
unix: fix format string vulnerability in freebsd.c
uv_set_process_title() was susceptible to a format string vulnerability:
$ node -e 'process.title = Array(42).join("%s")'
Segmentation fault: 11 (core dumped)
The fix is trivial - call setproctitle("%s", s) instead of setproctitle(s) -
but valgrind complains loudly about reads from and writes to uninitialized
memory in libc. It's not a libuv bug because the test case below triggers the
same warnings:
#include <sys/types.h>
#include <unistd.h>
int main(void)
{
setproctitle("%s", "test");
return 0;
}
That's why this commit replaces setproctitle() with sysctl(KERN_PROC_ARGS).
This commit reapplies commit a9f6f06, which got reverted in 69a6afe. The revert
turned out to be unnecessary.
PreviousNext