Repository navigation
Add regression tests for moving/appending slot children in realms - #206
Merged
Merged
Conversation
Covers the fix in 318f8f3: a node adopted by an ancestor realm and then moved into a nested one must not be duplicated in the nested realm's childNodes when it is moved again. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D8BqaBWWbTy75iFWfdbAHr
🦋 Changeset detectedLatest commit: 9d990dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 75.27% 75.55% +0.27%
==========================================
Files 15 15
Lines 1986 1988 +2
Branches 548 549 +1
==========================================
+ Hits 1495 1502 +7
+ Misses 136 130 -6
- Partials 355 356 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adoptNodes spliced childNodes with index -1 for nodes already adopted but not yet inserted (text nodes created from strings), removing the last child. Also dedupe nodes in insertNodesBefore. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D8BqaBWWbTy75iFWfdbAHr
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D8BqaBWWbTy75iFWfdbAHr
edoardocavazza
marked this pull request as ready for review
September 29, 2026 05:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
childNodes.Realm.append('text')(or any string) dropped the last slotted child.importNodesadopts the new text node, thenadoptNodesseesparentRealm === this, callsindexOf(-1) andsplice(-1, 1), removing the last child. Now the splice is guarded, andinsertNodesBeforededupes nodes soappend(c, c)insertsconce (as the DOM does). Includes a patch changeset.Verification
test/component.spec.tsxon Chromium: 84 passed.biome checkandtscclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01D8BqaBWWbTy75iFWfdbAHr