Repository navigation
changelog: fix and improve output - #174
Merged
Merged
Conversation
KanjiMonster
force-pushed
the
jogo_changelog_split_long_lines
branch
2 times, most recently
from
October 5, 2026 12:08
a5581b9 to
e8f3412
Compare
KanjiMonster
marked this pull request as ready for review
October 5, 2026 12:31
For comm to work, the cve lists need to be one item per line, not a single line, so do not echo them, as this would contatenate them together to one long line. Reported-by: Ben Lewis <ben.lewis@bisdn.de> Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
CVE numbers can have a variable number of digits, but sorting them with without any options will sort 12345 before 2345, putting them not in numerical order. Fix this by sorting them first by year (k2) then assigned number (k3). Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Each release can have a large number of fixed CVEs, especially for the kernel. Currently we print all fixed CVEs in one line, but this can lead to lines hundreds of characters long. This becomes hard to read in editors that do not auto-wrap. So use fold to automatically wrap lines at 80 characters, so limit the it to 78 to allow each line to be indented by 2 white spaces. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_changelog_split_long_lines
branch
from
October 7, 2026 15:06
e8f3412 to
7234186
Compare
KanjiMonster
marked this pull request as draft
October 7, 2026 15:06
KanjiMonster
marked this pull request as ready for review
October 8, 2026 08:21
b3n-l
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve and fix the fixed CVE list output:
First keep line breaks in the CVE lists before diff'ing them, as comm requires the items to be in lines to work. Without this, we may report previously addressed CVE as fixed.
Then sort the CVEs more naturally and make sure that CVE-2026-12345 is sorted after CVE-2026-2345.
Finally, each release can have a large number of fixed CVEs, especially for the kernel. Currently we print all fixed CVEs in one line, but this can lead to lines hundreds of characters long. This becomes hard to read in editors that do not auto-wrap.
So use fold to automatically wrap lines at 80 characters, so limit the it to 78 to allow each line to be indented by 2 white spaces.