Repository navigation
Conversation
Member
|
CLE is enough of an end-to-end system that I would strongly prefer we test against real binaries rather than mocks. Can you either synthesize the subject of your testcase into an actual ELF or find an in-the-wild redistributable ELF and commit it to angr/binaries? |
Author
|
hi, i've opened angr/binaries#276 with three synthetic ELF fixtures, assembly sources, and a rebuild script. They cover DWARF 4 and DWARF 5 filename indexing with relative and absolute directories, check on this pls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix file and directory lookups in DWARF 5 line tables, which use zero-based indices. Preserve legacy indexing and the implicit compilation directory for older versions.
Added regression coverage for DWARF 4/5 and relative/absolute directories.
Closes #548