Repository navigation
Conversation
Outside a git checkout, `git rev-parse HEAD` printed nothing, so the Makefile passed an empty `-PcommitId=`. `determineCommitId()` saw the property and used the empty value as the commit id. Pass `-PcommitId` only when `git rev-parse HEAD` succeeds. Otherwise Gradle falls back to "unknown". Assisted-by: Claude Sonnet 5.5
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, and the change conditionally passes the Git commit ID while preserving the existing fallback outside Git checkouts.
No open issues 🎉
What changed in this PR
Updates make build_release to pass the Git commit ID to Gradle only when git rev-parse HEAD succeeds, allowing builds outside a Git checkout to use the existing "unknown" fallback.
Changes:
- Resolves the commit ID conditionally.
- Omits
-PcommitIdwhen no Git commit is available. - Preserves commit ID handling inside Git checkouts.
| File | Description |
|---|---|
Makefile |
Conditionally supplies the Git commit ID to the Gradle release build. |
Review effort: Lite
jeqo
marked this pull request as ready for review
November 5, 2026 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outside a git checkout,
git rev-parse HEADprinted nothing, so the Makefile passed an empty-PcommitId=.determineCommitId()saw the property and used the empty value as the commit id.Pass
-PcommitIdonly whengit rev-parse HEADsucceeds. Otherwise Gradle falls back to "unknown".