Repository navigation
build(deps): upgrade React and react-dom to 19 - #243
Merged
Merged
Conversation
React 19 removed the global JSX namespace; import it from react in Card.tsx. @vitejs/plugin-react stays on 4.x: its 6.x needs vite 8. Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps react and react-dom from 18.3 to 19, with @types/react and @types/react-dom to match. Supersedes the split dependabot PRs #225 and #226, which each fail on their own: bumping @types/react to 19 without @types/react-dom leaves a peer-dependency conflict, so the two land together.
React 19 removed the global JSX namespace, so Card.tsx imports JSX from react. No other source change was needed; the 657 vitest cases and the production build pass unchanged.
@vitejs/plugin-react stays on 4.x; its 6.x (#224) requires vite 8, a separate two-major bump not taken here.