Repository navigation
fix(ghcli): cache unanswered login lookups - #232
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ghcli): cache unanswered login lookups
Closes #189
Repeated failed identity lookups currently launch
gh api useron everyrequest while holding the package mutex.
Cache errors and empty identity responses by token value for
forge.UnansweredTTL(30 seconds). Retry after expiry or when a newly readtoken changes, preserving existing successful caching and error semantics.
Caller cancellation is excluded from the cache. The existing five-minute
token refresh interval remains unchanged.
The subprocess remains under the package mutex, so concurrent callers share
one attempt per unanswered window. Regression reproduction: 20 calls launch
1 subprocess instead of 20.
Testing
rotation, successful caching, empty replies, cancellation, concurrency,
and lookup behavior without a token key.
go test ./...passed.git diff --checkpassed.golangci-lintis not installed.Related issue
Fixes #189 — A gh identity lookup that fails is repeated on every request.
Follows the unanswered-cache policy introduced in PR #164.