Repository navigation
test(board): date the day-after assertion from today - #234
Merged
Merged
Conversation
Every other date in the finished-slot case is relative to today, but the last assertion named a fixed day. It stood for "the day after the card was finished", which is only what that literal means until the calendar reaches it: on the day the two coincide the assertion asks whether the finish day itself keeps the card, and the answer is yes, so it fails. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <f@lex.la>8000
kvaps
approved these changes
Sep 19, 2026
Member
There was a problem hiding this comment.
Correct one-line fix. The literal date landed on DoneAt on exactly one calendar day and went red on correct behaviour; deriving it from today matches the rest of the test. This is the base of the stack, needed green for the four above it.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last assertion in
TestTeamGridShowsASlotFromItsWeekUntilItIsDoneused a hardcoded date, while every other date in that test is derived fromTodayIso(). The literal stood for "the day after the card was finished", which stops being true once the calendar reaches it.That misfires on exactly one day: the one where the literal lands on
DoneAt. There the assertion asks whether the finish day itself still holds the card, and it does, so the test goes red on correct behaviour. On any other day the literal missesDoneAt, the grid is empty there, and the assertion passes without exercising the rule.Now it asks for
today, like the rest of the test.