Repository navigation
Conversation
| | postgresql.tls.certificate.name | string | `"psql-server"` | Name of certificate | | ||
| | postgresql.tls.certificatesSecret | string | `"psql-server"` | Name of TLS secret | | ||
| | postgresql.tls.enabled | bool | `false` | Enable TLS for Postgresql | | ||
| | postgresql.enabled | bool | `false` | Enable a PostgreSQL instance for testing/developement. | |
There was a problem hiding this comment.
| | postgresql.enabled | bool | `false` | Enable a PostgreSQL instance for testing/developement. | | |
| | postgresql.enabled | bool | `false` | Enable a PostgreSQL instance for testing/developement. Production use is not supported. | |
a97f3bc to
9537244
Compare
| - name: POSTGRES_PASSWORD | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: {{ include "timed.postgresql.fullname" . }} | ||
| key: password |
There was a problem hiding this comment.
I would've dropped the secret entirely if not for it being expected to exist (as a secret) in other places
9537244 to
a7bb9a6
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
There was a problem hiding this comment.
🟡 Changes recommended
The default configuration leaves backend workloads referencing a PostgreSQL Secret that is no longer rendered, causing normal installations to fail, and the added description also contains a spelling error.
2 open issues
Review effort: Lite
| # -- Enable PostgreSQL Helm Chart (https://bitnami.com/stack/postgresql) for persistence | ||
| enabled: true | ||
| # -- Enable a PostgreSQL instance for testing/developement. Production use is not supported. | ||
| enabled: false |
| postgresql: | ||
| # -- Enable PostgreSQL Helm Chart (https://bitnami.com/stack/postgresql) for persistence | ||
| enabled: true | ||
| # -- Enable a PostgreSQL instance for testing/developement. Production use is not supported. |
Also ran
helm-docs, which hasn't been done i a while.