Repository navigation
fix(ci): recover baseline SQLite WAL startup race - #728
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence and fix
Upgrade job 128087988293 failed before seeding v0.20.0: its worker exited at
textindex.py→PRAGMA journal_mode=WALwithsqlite3.OperationalError: database is locked, while the API completed startup. Production hasrestart: unless-stopped, whereas the harness stopped immediately.Restart only the baseline worker for this specific traceback, at most twice within the existing startup budget. Preserve every failed attempt log. Initially start API and worker concurrently in both versions. Never retry the target version, API failures, migration failures or other exceptions. Check process liveness before and after readiness probes. All seeding, authentication, data retention, backup, exactly-once migration and idempotency checks are unchanged.
Seven stdlib regression tests run in Upgrade CI before the real upgrade, covering concurrent startup, recovery and logs, retry exhaustion, target fail-fast, unrelated errors, dead-worker readiness and API failure. Document the retry policy and add a changelog fragment.
Verification
bash -n ci/upgrade/upgrade.sh.python3 ci/upgrade/test_startup.py -v.ci/local-ci.sh --pr N, Docker upgrade and aggregate checks not run locally: this executor has materialized files but no Git checkout or Docker. PR CI must pass before merge; this draft is not a release-ready claim.Done questions