Repository navigation
Fix release image build; visible keyboard focus on the canvas - #31
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K4B4YKMC6fT9oWCCwWgt9S
A Playwright keyboard walkthrough found nodes and cables took Tab focus with nothing drawn (WCAG 2.4.7): studio.css and React Flow's .selectable:focus-visible both set outline:none. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K4B4YKMC6fT9oWCCwWgt9S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: both Pi image jobs in the Release workflow fail at pi-gen-action's "Removing runner components to increase disk build space" step (
/usr/bin/sudoexit code 100 from apt), so no image reaches the release. On the Studio canvas, Tab moves focus onto nodes and cables but nothing is drawn, so a keyboard user can't see where they are (WCAG 2.4.7).After: the image build frees disk in its own non-fatal step. A focused node gets a 2px brand outline and a focused cable a brand halo.
How:
increase-runner-disk-size: falseplus a "Free runner disk space" step (dotnet, Android SDK, GHC, CodeQL, boost, docker images, all|| true). Validated by a manual Pi image run on this branch.studio.cssfocus-visible rules; the node rule carries an extra.react-flowbecause React Flow's own.react-flow__node.selectable:focus-visible{outline:none}loads later.focus.test.tspins both rules (red without the CSS). Checked with a Playwright Tab walkthrough ofgadgetcast -devin Chromium: outlinesolid 2px rgb(8,112,143)on the node, halo on the cable; Enter selects and opens the inspector, arrows move. No screen-reader test.🤖 Generated with Claude Code
https://claude.ai/code/session_01K4B4YKMC6fT9oWCCwWgt9S