Repository navigation
fix(gadget): write absolute configfs symlink targets - #30
Merged
Merged
Conversation
configfs resolves a symlink's target against the caller's working directory, not the link's directory, so the relative "../../header/h" links failed on a real kernel with ENOENT and `gadgetcast gadget up` exited before binding the UDC. OS.Symlink now joins relative targets onto the link's directory. Verified on a Pi Zero 2 W (kernel 6.18): UDC state "configured", macOS enumerates the UVC camera and UAC2 audio. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C7ienWVsaHE85pDmB62jxz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gadgetcast gadget upfailed on real hardware:symlink ../../header/h .../control/class/fs/h: no such file or directory.OS.Symlinkjoins relative targets onto the link's directory.Planis unchanged.Test plan
TestOSSymlinkWritesAbsoluteTarget(red before, green after)configured, macOS lists the GadgetCast UVC camera and UAC2 input/output🤖 Generated with Claude Code
https://claude.ai/code/session_01C7ienWVsaHE85pDmB62jxz