Repository navigation
fix(release): skip Homebrew cask upload when tap token is unset - #6
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hxxLWW2T83zxJLY5Ha1MY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
What
A tagged release no longer fails when the
HOMEBREW_TAP_GITHUB_TOKENsecret (or theadeelahmad/homebrew-taprepo) is missing. The cask is still rendered intodist/, but its upload is skipped and the rest of the release ships.Why
skip_upload: autoonly skips prereleases, so a stable tag tried to push the cask with an empty token and failed, even though the workflow comment said the tap update would be skipped.How tested
skip_uploadis now templated:truewhen the token is empty,autootherwise. Validated with GoReleaser v2 locally (goreleaser check, plus a non-snapshotreleaseagainst a throwaway local tag with GitHub release publishing disabled):token empty →
homebrew cask: pipe skipped … reason=brew.skip_upload is settoken set → falls through to
autobehaviour as beforeRelease config only; no Go code changed
make test-integration(n/a)Security
🤖 Generated with Claude Code
https://claude.ai/code/session_012hxxLWW2T83zxJLY5Ha1MY
Generated by Claude Code