8000 Add support for layer/path metadata inheritance by abey79 · Pull Request #187 · abey79/vsvg · GitHub
[go: up one dir, main page]
Skip to content

Add support for layer/path metadata inheritance - #187

Open
abey79 wants to merge 2 commits into
pr3-hatch-algofrom
pr4-metadata-refactor
Open

Add support for layer/path metadata inheritance#187
abey79 wants to merge 2 commits into
pr3-hatch-algofrom
pr4-metadata-refactor

Conversation

@abey79
@abey79 abey79 commented Jan 4, 2026 •
edited
Loading
Copy link
Copy Markdown
Owner

This PR refactors path metadata to support inheritance semantics, including:

  • PathMetadata fields are now Option<T>: None means "inherit from layer" (or SVG default if layer also `None`)
  • Added LayerMetadata::default_path_metadata: Layer-level defaults that paths can inherit from
  • SVG export writes only non-None values: Layer defaults on <g>, path overrides on <path>, letting SVG handle inheritance
  • SVG reader promotes common metadata: After loading, if all paths in a layer share the same value, it's moved to layer defaults and cleared from paths. This is needed because usvg flattens everything, and lead to duplication of layer-level metadata to all paths, leading to file size bloat.
  • Added ResolvedPathMetadata: For display purposes (vsvg-viewer) where concrete values are needed
  • Added PathMetadata::merge(): Conflict semantics (both Some but different → None)

This is part 4 of 6 in a stack made with GitButler:

This was referenced Jan 4, 2026
Merged
Merged
Open
@abey79 abey79 added vsvg Relates to vsvg breaking Breaking change feature New feature labels Jan 4, 2026
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from 0701cd0 to e22da9c Compare January 18, 2026 09:50
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from e22da9c to 7268e0f Compare January 18, 2026 12:41
@abey79 abey79 mentioned this pull request Jan 18, 2026
Open
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from 7268e0f to c064346 Compare February 8, 2026 10:05
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from c064346 to 953df45 Compare February 15, 2026 10:00
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from 953df45 to 69fbf67 Compare February 21, 2026 13:08
@abey79 abey79 mentioned this pull request Feb 21, 2026
Open
@abey79
abey79 force-pushed the pr4-metadata-refactor branch 2 times, most recently from a0db2dd to 10d677b Compare February 22, 2026 20:28
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from 10d677b to 69f7d5c Compare February 22, 2026 20:29
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from 69f7d5c to 2819fe4 Compare February 22, 2026 21:03
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from 2819fe4 to 54fd21d Compare February 22, 2026 21:07
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from 54fd21d to feb5528 Compare February 22, 2026 21:31
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from feb5528 to 895ddc1 Compare March 1, 2026 08:49
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from 895ddc1 to 6cb4ede Compare March 1, 2026 09:15
@abey79
abey79 force-pushed the pr4-metadata-refactor branch from 6cb4ede to bd25ac5 Compare March 1, 2026 09:36

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking Breaking change feature New feature vsvg Relates to vsvg

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@abey79
0