Repository navigation
fix: clear clippy 1.99 double_must_use - #115
Merged
Merged
Conversation
async-trait 0.1.91 stamps #[must_use] with no message onto every async trait method. Clippy 1.99 treats that as double_must_use because the pinned boxed future is already must_use, and CI on stable has been red since a9ebe8f. 0.1.92 stops emitting the attribute. The future stays must_use through its type, which is the fix the lint asks for. Workflow actions are pinned to full commit SHAs. rust-toolchain is the v1 commit on master, with toolchain: stable passed explicitly, because a SHA pin does not select the stable channel the way @stable did. Publish still uses CARGO_REGISTRY_TOKEN the same way. Dependabot checks github-actions and cargo weekly, each in one group. Signed-off-by: Avelino <31996+avelino@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified in the dependency update, verified action pins, or Dependabot configuration; CI remains pending.
0 open findings
What changed in this PR
Updates async-trait to address Clippy’s double_must_use failure in the Rust CLI, and hardens dependency maintenance.
Changes:
- Updates
async-traitto 0.1.92. - Pins actions across five workflows to full commit SHAs while preserving stable Rust.
- Adds weekly grouped Dependabot updates for Cargo and GitHub Actions.
| File | Description |
|---|---|
| Cargo.toml | Raises the minimum async-trait version. |
| Cargo.lock | Locks the updated version and checksum. |
| .github/workflows/release.yml | Pins release actions and explicitly selects stable Rust. |
| .github/workflows/release-beta.yml | Pins beta-release actions and selects stable Rust. |
| .github/workflows/publish-homebrew.yml | Pins the checkout action. |
| .github/workflows/publish-crate.yml | Pins publishing actions and selects stable Rust. |
| .github/workflows/ci.yml | Pins CI actions and selects stable Rust. |
| .github/dependabot.yml | Configures weekly grouped dependency updates. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clippy 1.99
double_must_usefails CI on main (since a9ebe8f).async-trait0.1.91 adds#[must_use]with no message on async trait methods whose return type is already must_use. 0.1.92 removes that attribute. The future stays must_use because the type is.Actions in all five workflows are pinned to full SHAs, with the version in a comment.
dtolnay/rust-toolchainis the v1 commit on master and now passestoolchain: stable, so it still installs stable. The publish job still setsCARGO_REGISTRY_TOKENand runs the samecargo publishcommand..github/dependabot.ymlupdatesgithub-actionsandcargoweekly, each in one group.How it was tested
Docs:
double_must_use: lint index. The lint checks for#[must_use]with no further information on a function that already returns a must_use type. The attribute is not needed. Alternatively, add text to the attribute. Context7resolve-library-idfor rust-clippy returned "Monthly quota exceeded" on every call, so this is the official page.dtolnay/rust-toolchainREADME: a full SHA must be in master history, andtoolchainmust be passed when the ref is not@stable.package-ecosystemvaluesgithub-actionsandcargo,schedule.intervalweekly, andgroupswithpatterns.Local, Rust 1.99.0 (b940084d7 2026-09-28):
CI on this branch is green: https://github.com/avelino/mcp/actions/runs/37766685021 (
testanddockerboth succeeded, includingcargo clippy -- -D warningsandcargo test).Could not test:
CARGO_REGISTRY_TOKEN. Steps other than the action pins were left as they were.