Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows clipboard reader locks the clipboard memory without unlocking it. Add a guard that unlocks the handle after the text is copied, before the clipboard is closed. Also convert GlobalSize's byte count to UTF-16 units so a missing terminator cannot make the reader scan past the allocation.
The regression fails before the fix with a lock count of one after reading. Tests use Windows memory allocations to check repeated reads, Unicode text, unterminated data and a failed lock, without changing the clipboard.
On Windows, all four all-feature library tests pass, the all-feature build passes, and clippy completes with existing warnings. The changed file passes rustfmt. The full test run has three graphics doc-test failures from OpenGL calls without an initialized context, and repository-wide formatting also fails in unchanged files. An interactive clipboard round trip was not tested.
Fixes #549.