Repository navigation
feat: add passthru.updateScript where nurl fetchers are known - #768
Merged
figsoda merged 3 commits intoApr 10, 2026
Merged
Conversation
There used to be a convention to sort arguments by the order they are used, which nix-init follows. It was removed[1] due to the lack of tooling to enforce it, but it doesn't hurt for nix-init to keep following it for consistency. [1]: NixOS/nixpkgs#247424
Member
|
thanks |
Contributor
|
As I tried to explain in NixOS/nixpkgs#502056 and #642, this PR wasn't fully accurate. Here's a fix: |
figsoda
pushed a commit
that referenced
this pull request
Jul 6, 2026
PR #768 added `passthru.updateScript = nix-update-script { };` for all packages where the fetcher is known. However, as clarified in [NixOS/nixpkgs#502056](NixOS/nixpkgs#502056), this is redundant for GitHub-hosted packages: `nixpkgs-update` (r-ryantm) already discovers and updates those automatically via native GitHub releases discovery, without needing an explicit `updateScript`. `nix-update-script` is genuinely useful for forges like GitLab and Gitea where Repology coverage is weaker and `nix-update` finds new versions more reliably. Restrict the condition to known fetchers other than `fetchFromGitHub`, remove `nix-update-script` from the GitHub-based test fixtures, and add a new `fetchFromGitLab` test (`gitlab.com/emilua/beast`) that exercises the case where `nix-update-script` is correctly emitted. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
passthru.updateScript = nix-update-script { };where nurl fetchers are known.closes #642.
dsisclaimer i used a coding agent in the creation of this patch.