Repository navigation
Conversation
also renames BuildType -> Builder
- renames RustVendor -> CargoVendor to be consistent with the cli option - removes the outdated conditional importCargoLock preference, since fetchCargoVendor works with git dependencies unlike the old fetchCargoTarball
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you @dhnaranjo for working on #649. This pull request is built on top of that, and these are the few major differences
--builderexpects arguments likebuildGoModulerather thango-mod, so the options are more predictable if you are already familiar with nixpkgs--version-nameis now named--version, this is so the flags are more predictable. however this changes the behavior ofnix-init --version foofrom printing the version to specifyingversion = "foo".nix-init --versionwithout any extra arguments still works as expectedfrontendmodule. this opens up possibilities in the future to implement alternative frontends (json?)This is not very well tested at the moment as we don't have any end-to-end testing. I will work on more thoroughly testing this in the next few days before I merge this
closes #648
PS: the diff is pretty big, it's probably easier to read commit-by-commit