Repository navigation
buildGoModule: use finalAttrs - #639
Closed
katexochen wants to merge 1 commit into
Closed
katexochen wants to merge 1 commit into
katexochen wants to merge 1 commit into
Conversation
Signed-off-by: Paul Meyer <katexochen0@gmail.com>
katexochen
force-pushed
the
buildGoModule-finalAttrs
branch
from
July 22, 2025 09:18
be80a85 to
e177321
Compare
Member
Author
figsoda
reviewed
Jan 10, 2026
Member
There was a problem hiding this comment.
I believe all the builders we use support finalAttrs now, so we can make the switch for all of them
| version = {version:?}; | ||
|
|
||
| src = {src_expr}; | ||
| src = {src_expr_final_attrs}; |
Member
There was a problem hiding this comment.
the changelog also mentions the version, so that needs to be changed as well
Member
|
I can start working on this if you haven't already |
Member
Author
I don't think I'll find the time, so happy to give this away, thanks! |
Member
|
opened #666 since I can't push to this branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.