8000 Reduce allocations in keys#read key by Antsiscool · Pull Request #766 · mongomapper/mongomapper · GitHub
[go: up one dir, main page]
Skip to content

Reduce allocations in keys#read key #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smtlaissezfaire merged 2 commits into from
Nov 3, 2026
Merged

Reduce allocations in keys#read key #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37652fa
Use Symbol#name when available in MongoMapper::Plugins::Keys#read_key
Antsiscool Oct 26, 2026
cb37e69
Reduce branching
Antsiscool Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/mongo_mapper/extensions/symbol.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,7 @@ def from_mongo(value)

class Symbol
extend MongoMapper::Extensions::Symbol

# Symbol#name was added in Ruby 3.0. Remove when Ruby 2.x support is dropped.
alias_method :name, :to_s unless method_defined?(:name)
end
11 changes: 6 additions & 5 deletions lib/mongo_mapper/plugins/keys.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,12 +378,13 @@ def read_key(key_name)
key_name_sym = key_name.to_sym
if @_dynamic_attributes && @_dynamic_attributes.key?(key_name_sym)
@_dynamic_attributes[key_name_sym]
elsif key = keys[key_name.to_s]
if key.ivar && instance_variable_defined?(key.ivar)
value = instance_variable_get(key.ivar)
elsif key = keys[key_name_sym.name]
ivar = key.ivar
if ivar && instance_variable_defined?(ivar)
value = instance_variable_get(ivar)
else
if key.ivar
instance_variable_set key.ivar, key.get(nil)
if ivar
instance_variable_set ivar, key.get(nil)
else
@_dynamic_attributes[key_name_sym] = key.get(nil)
end
Expand Down
Loading
0