8000 MOTOR-1485 Fix startup failures due to tox and pytest updates by blink1073 · Pull Request #432 · mongodb/motor · GitHub
[go: up one dir, main page]

Skip to content

MOTOR-1485 Fix startup failures due to tox and pytest updates - #432

Merged
blink1073 merged 2 commits into
mongodb:masterfrom
blink1073:MOTOR-1485
Nov 3, 2026
Merged

blink1073 merged 2 commits into
mongodb:masterfrom
blink1073:MOTOR-1485

Conversation

@blink1073
@blink1073 blink1073 commented Nov 2, 2026 •
Copy link
Copy Markdown
Member

Summary

The 2026-10-31 weekly Motor Build failed all 617 tasks before a test ran, on breaking changes from tox 4.67.5 and pytest 9.2.0. Pins known-good versions to unblock the weekly build. Fixes MOTOR-1485.

Changes

  • Pin tox 4.67.6 in the Evergreen runner.
  • Pin pytest 9.2.0 in the test requirements.
  • Set asyncio_default_fixture_loop_scope to session so pytest-asyncio's configure-time deprecation warning cannot fail the run under filterwarnings = ["error"].

Testing

  • Reproduced the pytest 9.2.0 INTERNALERROR locally; with session set, the same run collects 415 tests cleanly.
  • Verified tox 4.67.6 stages the package through the path that failed on 4.67.5.
  • The tox failure only reproduces on Evergreen hosts, so that half verifies on push.

tox 4.67.5 added a package-staging permission check that fails on
Evergreen hosts and aborted every Linux and macOS task before any test
ran; pin tox to 4.67.6, which drops the check.

pytest 9.2.0 applies warning filters during pytest_configure, turning
pytest-asyncio's unset asyncio_default_fixture_loop_scope warning into
an INTERNALERROR; pin pytest to 9.2.0 and set the option to session
scope.
Copilot AI left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The Evergreen-host-specific tox regression cannot be reproduced from this checkout, so approval should await verification that tox 4.67.6 completes the affected staging path.

No open issues 🎉

What changed in this PR

This pull request stabilizes Motor’s weekly build by pinning known-good tox and pytest versions and configuring pytest-asyncio to prevent a deprecation warning from failing test startup.

Changes:

  • Pins pytest to 9.2.0 in the test requirements.
  • Pins tox to 4.67.6 in the Evergreen runner.
  • Sets pytest-asyncio’s default fixture loop scope to session.
File Description
requirements/​test.txt Pins pytest to 9.2.0.
pyproject.toml Configures pytest-asyncio’s default fixture loop scope.
.evergreen/​run-tox.sh Pins the Evergreen tox version to 4.67.6.

Review effort: Lite

@blink1073
blink1073 marked this pull request as ready for review November 2, 2026 22:59
@blink1073
blink1073 requested a review from a team as a code owner November 2, 2026 22:59
@blink1073
blink1073 requested a review from NoahStapp November 2, 2026 22:59
@blink1073
blink1073 merged commit 1a0afa4 into mongodb:master Nov 3, 2026
20 checks passed
@blink1073
blink1073 deleted the MOTOR-1485 branch November 3, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0