Repository navigation
Fix length for per cpu PMU reset bitmap since max_cpus cpus > 64 - #65
Merged
Meandres merged 1 commit intoOct 22, 2026
Merged
Conversation
pmu_reset_once() kept its done flags in one 64-bit word and asserted sched::max_cpus <= 64. Since max_cpus went to 256 (#22) that assert fails and the aarch64 build breaks. Keep one bit per cpu in as many words as max_cpus needs, rounded up, so it does not depend on max_cpus being a multiple of 64. Tested on c8g.48xlarge (192 vCPUs, together with the GIC max-cpus fix): a second PerfEvent on every cpu leaves the running cycle counter enabled and counting; with the reset forced on every call the same test fails on all cpus. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bitmap doesn't work for instances > 64 cores since the width of one atomic uint64_t isn't enough