Repository navigation
A sandbox checklist for method and dataset pull requests - #85
Merged
Merged
Conversation
A pull request that adds or changes a method or a dataset and starts a process or changes what a sandbox shows answers two items: every process reuses the framework's sandbox (hermit.sandbox or hermit/isolate.py, its needs in the existing settings, one sandbox record linked), with a reason for anything that cannot; and a change to the sandbox itself is a core change agreed with the core team first. The prepare-pr skill and CONTRIBUTING point to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Methods and datasets should reuse the unified sandbox from #78 rather than build isolation of their own, and the sandbox itself should change only as a core change. This adds a checklist for that, in the same place as the test checklist:
.agents/skills/prepare-pr/references/sandbox-checklist.md, two items for a pull request that adds or changes a method or a dataset and starts a process or changes what a sandbox shows:hermit.sandboxorhermit/isolate.py, with its needs declared in the existing settings, and onesandbox/<role>-<n>.jsonfrom a run of the change is linked. A process that cannot use this abstraction states why and how it is confined instead.hermit/sandbox.py,hermit/sandbox_relay.py,hermit/isolate.py, the Trainer's evolver sandbox or their defaults links the issue where it was agreed with the core team, and is answered under Core changes in the general checklist..agents/skills/prepare-pr/SKILL.mdandCONTRIBUTING.mdpoint to it.Validation
Documentation only: the links resolve from each file (
docs/guides/sandbox.md, the general checklist, the new checklist).Review
🤖 Generated with Claude Code