Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
CliAgent(hermit/agent/base/cli.py) was shared bycodexandclaude, but every per-CLI difference besides the command was an inlineif backend == "codex"check spread overcli.py,records.py,trajectory.py,interface.py,endpoint.pyandisolate.py.Now
CliAgentis one shared runner (isolation, home, sign-in, tool server, process, the stream's safety). Each CLI is a subclass whose hooks hold what is its own:programhome_env,prepare_home,user_home)served,notices,last_message,parse,steps,adjust_usage)CLISlists every CLI.make(),isolate.CLI_HOMESand the chat endpoint use it;trajectory.pyhas a small reader registry of its own.Results and error messages are identical.served,notices,last_message,web_search_args,parse_log, …) stay as wrappers.programattribute.agent-layers.md, a "New CLI Base Agent" row in the developer guide, a CHANGELOG entry.Validation
Run on Linux (bubblewrap 0.9.0, Python 3.12, codex-cli 0.166.0, Claude Code 2.1.317). Each tree in its own venv:
origin/main(11acf57)python -m pytest--integration(test_sandbox.py,test_ahe_hosts.py)examples/clbench_databaseparity tests, which already fail onmain.CLISimplements every hook and thatmake()builds it under each name. It fails for a CLI that leaves a hook out.Review
isolate.py, restructured so a new CLI is one subclass.tests/core/test_cli_agent.py, needs no files, network or sign-in, and runs in 0.13 s.