Repository navigation
Add AWS IAM login profile data fetcher - #85
donghwikim2 wants to merge 6 commits into
Conversation
2614ea2 to
76302c9
Compare
c97e485 to
9783dc4
Compare
| * @author Donghwi KIm | ||
| * @since 1.0.0 | ||
| */ | ||
| public class AwsLoginProfile extends AwsWrapper<LoginProfile> { |
There was a problem hiding this comment.
Prefix names with service, e.g. AwsIamLoginProfile etc.
There was a problem hiding this comment.
I renamed it to AwsIamLoginProfile
| if ( Objects.equals( e.awsErrorDetails().errorCode(), | ||
| "NoSuchEntity" ) ) { | ||
| continue; |
There was a problem hiding this comment.
Can you add a note why ignoring this is okay?
There was a problem hiding this comment.
I added comment now
// Ignore NoSuchEntity - not all users have login profiles for console access
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for fetching AWS IAM login profile data, which provides information about user console access configurations. Additionally, it enhances the S3 bucket policy statement to include action information.
Key changes:
- New
LoginProfileDataFetcherandAwsIamLoginProfileclasses to fetch and represent IAM login profiles - Registration of the login profile data fetcher in the IAM schema provider
- Addition of
actionJsonValuefield toAwsBucketPolicyStatementfor more complete policy information
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| LoginProfileDataFetcher.java | Implements data fetcher to retrieve IAM login profiles for users with console access |
| AwsIamLoginProfile.java | Model class wrapping AWS SDK LoginProfile data |
| AwsIAMSchemaProvider.java | Registers the new LoginProfileDataFetcher instance |
| Main.java | Adds example registration and query for login profiles |
| AwsBucketPolicyStatement.java | Extends record to include action field from S3 bucket policies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ws/iam/AwsIamLoginProfile.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ws/iam/LoginProfileDataFetcher.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Merged via 642955c |
No description provided.