Repository navigation
test: fix flaky Keeper reconnect check in test_010064 - #2143
Merged
Merged
Conversation
…est_010064 connected_time in system.zookeeper_connection is computed at query time as now() - session uptime, both in whole seconds, so it jitters by 1s within the same session and made the "CHI does not reconnect to Keeper" check flaky. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Python 3.13.18 removed lzma._MODE_CLOSED, which testflows.core still uses in _core/compress.py (also in the latest 2.0.261028 release). Every tfs transform and the report step failed with "module 'lzma' has no attribute '_MODE_CLOSED'", so CI produced no nice/short logs or results report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alex-zaitsev
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_010064fails at CHI does not reconnect to Keeper even though nothing reconnected, e.g.connected_time07:54:55 -> 07:54:56In both runs the operator log shows no reconnect: the CHK reconcile had no work, the CHI reconcile was skipped ("resolved zookeeper endpoints unchanged"), and the Keeper pod was not restarted.
system.zookeeper_connection.connected_timeis not stored. ClickHouse computes it at query time astime(nullptr) - zookeeper->getSessionUptime()(StorageSystemZooKeeperConnection.cpp). Both values are whole seconds, so it jitters by ±1s within the same session.The check now compares
client_id(the Keeper session id) instead. It changes when ClickHouse opens a new session and stays the same otherwise. The rescale step further down only checks that ClickHouse is still connected, so it is unchanged.Checked locally on orbstack (
--native, operator:devbuilt from this commit, GitSHAa3344abde):test_010064passed twice, 94/94 and 93/93 steps ok. On26.3.33.10001.altinitystable, the two replicas reportedclient_id1 and 2.