8000 fix: build a cluster-wide cache when watching all namespaces by Kitio-Tek · Pull Request #2124 · Altinity/clickhouse-operator · GitHub
[go: up one dir, main page]
Skip to content

fix: build a cluster-wide cache when watching all namespaces #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kitio-Tek wants to merge 3 commits into
base: 0.28.0
Choose a base branch
from
Open

fix: build a cluster-wide cache when watching all namespaces #2124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7f55fc
fix: build a cluster-wide cache when watching all namespaces
Kitio-Tek Oct 29, 2026
e1f25fd
Merge branch '0.28.0' into cache-namespace-all-cluster-wide
Slach Nov 3, 2026
dab58aa
Merge branch '0.28.0' into cache-namespace-all-cluster-wide
Slach Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cmd/operator/app/informer_scope_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,16 @@ func TestKeeperCacheOptionsNarrowsEveryServedType(t *testing.T) {
}

}

// TestCacheOptionsWatchAllNamespacesBuildsClusterWideCache covers watch.namespaces unset, where
// GetCacheNamespaces returns only NamespaceAll. controller-runtime builds a multi-namespace cache
// whenever DefaultNamespaces has an entry, and in v0.18 its List refuses any namespace that is not
// a key, so a lone "" key made every namespaced list in CHK discovery fail.
func TestCacheOptionsWatchAllNamespacesBuildsClusterWideCache(t *testing.T) {
log := funcr.New(func(prefix, args string) {}, funcr.Options{})
all := []string{meta.NamespaceAll}

require.Empty(t, newKeeperCacheOptions(log, all).DefaultNamespaces, "keeper cache must be cluster-wide when watching all namespaces")
require.Empty(t, newBackupCacheOptions(log, all).DefaultNamespaces, "backup cache must be cluster-wide when watching all namespaces")
require.Len(t, newKeeperCacheOptions(log, []string{"ns1"}).DefaultNamespaces, 1, "a named namespace must stay scoped")
}
7 changes: 7 additions & 0 deletions cmd/operator/app/init_retry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"errors"
"time"

meta "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/wait"
"sigs.k8s.io/controller-runtime/pkg/cache"

Expand Down Expand Up @@ -101,7 +102,13 @@ func initWithRetry(ctx context.Context, component string, init func(context.Cont
// DNS labels, enabling per-namespace cache scoping. It falls back to NamespaceAll when the include
// list is unset or any watch namespace is a regexp pattern (the controllers' Reconcile guard
// handles filtering in that case). ByObject entries that leave Namespaces nil inherit this scoping.
//
// NamespaceAll alone yields nil, so the cache is a single cluster-wide one. A lone "" key would make
// controller-runtime build a multi-namespace cache whose List rejects every concrete namespace.
func newCacheNamespaces(cacheNamespaces []string) map[string]cache.Config {
if len(cacheNamespaces) == 1 && cacheNamespaces[0] == meta.NamespaceAll {
return nil
}
defaultNamespaces := make(map[string]cache.Config)
for _, ns := range cacheNamespaces {
defaultNamespaces[ns] = cache.Config{}
Expand Down
0