8000 fix: add chi-/chk- prefixes to PDB names to prevent naming conflicts by karnzx · Pull Request #1838 · Altinity/clickhouse-operator · GitHub
[go: up one dir, main page]
Skip to content
< 7FFF link rel="preload" as="image" href="https://github.githubassets.com/assets/copilot-e2b89335a66dba00.png"/>

fix: add chi-/chk- prefixes to PDB names to prevent naming conflicts #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karnzx wants to merge 1 commit into from
Closed

fix: add chi-/chk- prefixes to PDB names to prevent naming conflicts #1838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion pkg/model/common/creator/pdb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,37 @@
package creator

import (
"fmt"

policy "k8s.io/api/policy/v1"
meta "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/intstr"

apiChk "github.com/altinity/clickhouse-operator/pkg/apis/clickhouse-keeper.altinity.com/v1"
api "github.com/altinity/clickhouse-operator/pkg/apis/clickhouse.altinity.com/v1"
"github.com/altinity/clickhouse-operator/pkg/interfaces"
)

// CreatePodDisruptionBudget creates new PodDisruptionBudget
func (c *Creator) CreatePodDisruptionBudget(cluster api.ICluster) *policy.PodDisruptionBudget {
// Determine prefix based on CR type
var prefix string
switch c.cr.(type) {
case *api.ClickHouseInstallation:
prefix = "chi-"
case *apiChk.ClickHouseKeeperInstallation:
prefix = "chk-"
default:
prefix = ""
}

return &policy.PodDisruptionBudget{
TypeMeta: meta.TypeMeta{
Kind: "PodDisruptionBudget",
APIVersion: "policy/v1",
},
ObjectMeta: meta.ObjectMeta{
Name: c.nm.Name(interfaces.NameClusterPDB, cluster),
Name: fmt.Sprintf("%s%s-%s", prefix, cluster.GetRuntime().GetAddress().GetCRName(), cluster.GetRuntime().GetAddress().GetClusterName()),
Namespace: c.cr.GetNamespace(),
Labels: c.macro.Scope(c.cr).Map(c.tagger.Label(interfaces.LabelPDB, cluster)),
Annotations: c.macro.Scope(c.cr).Map(c.tagger.Annotate(interfaces.AnnotatePDB, cluster)),
Expand Down
Loading
0