Repository navigation
Add rbac/config/named_collections_restore_always options - #1598
Merged
Merged
Conversation
restore and restore_remote restore RBAC, configs and named collections only when --rbac/--configs/--named-collections is passed, there was no config counterpart of *_backup_always for restore. The new general->*_restore_always options enable the same flags from config. All three default to false: RBAC and configs restore overwrite existing objects/files and restart clickhouse-server, named collections restore drops and re-creates same-named SQL collections and fails when the name is defined in XML on the target server. Options are applied before embedded ON CLUSTER worker reset (initiator only restores them) and after cloud layout detection (restore_cloud doesn't support these flags). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generaloptionsrbac_restore_always,config_restore_always,named_collections_restore_always(envRBAC_RESTORE_ALWAYS,CONFIG_RESTORE_ALWAYS,NAMED_COLLECTIONS_RESTORE_ALWAYS), restore-side counterparts of*_backup_always.--rbac/--configs/--named-collectionsforrestoreandrestore_remote(including--streaming). A CLI flag can't be switched off by config.false, because these restores are destructive:restart_command;DROP NAMED COLLECTION IF EXISTS+CREATEfor every collection in backup, and fails if the same name is defined in XML config on the target server.restore_remote->restore_cloudisn't rejected).Manual.mdandReadMe.mdregenerated viagenerate_manual.sh; testflowsdefault_configsnapshot updated.Test plan
TestApplyRestoreAlwaysunit testgo test ./...default-config/print-configwith env overrides show the new keys in snapshot order🤖 Generated with Claude Code