8000 Retry S3 NoSuchUpload errors by sanasol · Pull Request #1580 · Altinity/clickhouse-backup · GitHub
[go: up one dir, main page]

Skip to content

Retry S3 NoSuchUpload errors - #1580

Merged
Slach merged 4 commits into
Altinity:masterfrom
sanasol:fix/retry-nosuchupload
Sep 30, 2026
Merged

Slach merged 4 commits into
Altinity:masterfrom
sanasol:fix/retry-nosuchupload

Conversation

@sanasol
@sanasol sanasol commented Sep 28, 2026 •
Copy link
Copy Markdown

Fixes #1579.

Exclude NoSuchUpload from permanent not-found errors so uploads can retry with a new multipart session. Covers typed/wrapped SDK errors and string fallback; preserves NoSuchKey, cancellation, and allow_missing_files_on_download behavior.

Tests: regression fails before the fix; passes after:

go test ./pkg/storage ./pkg/backup -run '^(TestIsNotFoundErr.*|TestClassify|TestCopyObjectRetryClassify|TestSkipMissingPartNoSuchUpload)$' -count=1

AI-assisted (Codex).

@Slach
Slach commented Sep 30, 2026
Copy link
Copy Markdown
Collaborator

@sanasol thanks for contribution

@Slach
Slach merged commit fc3860a into Altinity:master Sep 30, 2026
30 checks passed
@Slach Slach added this to the 2.8.2 milestone Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3 NoSuchUpload HTTP 404 aborts uploads without retry in v2.8.1

2 participants

0