Paths

Table of Contentst

Differential D332838

Bug 2080792 - Move EvalOptions::setUseInnerBindings() to match getter/setter order. r=arai
ClosedPublic
Actions

Authored by cemase on Mon, Oct 12, 10:49 AM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Oct 15, 10:49 AM

	Unknown Object (File)
	Thu, Oct 15, 3:14 AM

	Unknown Object (File)
	Thu, Oct 15, 3:03 AM

	Unknown Object (File)
	Thu, Oct 15, 3:01 AM

Subscribers

None

Details

Reviewers

Commits

rFIREFOXAUTOLAND3627d7bd06d4: Bug 2080792 - Move EvalOptions::setUseInnerBindings() to match getter/setter…

Bugzilla Bug ID

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

cemase created this revision.Mon, Oct 12, 10:49 AM

Herald added a project: secure-revision. · View Herald TranscriptMon, Oct 12, 10:49 AM

Harbormaster completed remote builds in B1062304: Diff 1403092.Mon, Oct 12, 10:49 AM

phab-bot published this revision for review.Mon, Oct 12, 10:49 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

arai requested changes to this revision.Mon, Oct 12, 12:56 PM

arai added inline comments.

js/src/debugger/Debugger.h
436	While you're here, can you put an empty line here, so that the distinction between getter, setter, others are clearer?
439–442	Please flip them, given that `kind_` is the last field.
449–455	Here too.

This revision now requires changes to proceed.Mon, Oct 12, 12:56 PM

cemase requested review of this revision.Mon, Oct 12, 1:16 PM

cemase updated this revision to Diff 1403206.

cemase marked 3 inline comments as done.

Thank you!

This revision is now accepted and ready to land.Tue, Oct 13, 2:06 AM

Closed by commit rFIREFOXAUTOLAND3627d7bd06d4: Bug 2080792 - Move EvalOptions::setUseInnerBindings() to match getter/setter… (authored by lochipi, committed by arai_a@mac.com <arai_a@mac.com>). · Explain WhyTue, Oct 13, 2:14 AM

This revision was automatically updated to reflect the committed changes.

arai_a@mac.com <arai_a@mac.com> added a commit: rFIREFOXAUTOLAND3627d7bd06d4: Bug 2080792 - Move EvalOptions::setUseInnerBindings() to match getter/setter….

Revision Contents
Changeset List

Path

Size

js/

src/

debugger/

12 lines

Diff 1403896

js/src/debugger/Debugger.h

Loading...