Details

Reviewers

Group Reviewers

firefox-svg-reviewers
firefox-style-system-reviewers

Commits

rFIREFOXAUTOLAND73497fd0b250: Bug 1815540 - Make SVG geometry independent of pointer-events. r=longsonr…

Bugzilla Bug ID

1815540

Summary

Track the stroke width as part of ink overflow if needed, to make sure
we do the hit-testing right without affecting mRect.

Port dom/svg/test/test_pointer-events-1*.xhtml to WPT so that it has
some coverage.

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

emilio created this revision.Mon, Sep 21, 10:30 PM

Herald added a project: secure-revision. · View Herald TranscriptMon, Sep 21, 10:30 PM

phab-bot published this revision for review.Mon, Sep 21, 10:30 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: firefox-style-system-reviewers. · View Herald TranscriptMon, Sep 21, 10:30 PM

Herald added a subscriber: zrhoffman. · View Herald Transcript

link

Harbormaster failed remote builds in B1049200: Diff 1384118!Mon, Sep 21, 10:56 PM

reviewbot added a project: testing-approved.Mon, Sep 21, 11:10 PM

Harbormaster completed remote builds in B1049203: Diff 1384124.Mon, Sep 21, 11:10 PM

rebase

longsonr accepted this revision.Tue, Sep 22, 8:18 AM

longsonr added inline comments.

layout/svg/SVGGeometryFrame.cpp
279	I think you need to call SVGContextPaint* contextPaint = SVGContextPaint::GetContextPaint(GetContent()); here and pass that to GetStrokeWidth as the second argument.

This revision is now accepted and ready to land.Tue, Sep 22, 8:18 AM

Harbormaster completed remote builds in B1049445: Diff 1384447.Tue, Sep 22, 8:48 AM

emilio updated this revision to Diff 1384506.Tue, Sep 22, 8:49 AM

Harbormaster completed remote builds in B1049477: Diff 1384506.Tue, Sep 22, 9:14 AM

Closed by commit rFIREFOXAUTOLAND73497fd0b250: Bug 1815540 - Make SVG geometry independent of pointer-events. r=longsonr… (authored by emilio, committed by ealvarez@mozilla.com <ealvarez@mozilla.com>). · Explain WhyTue, Sep 22, 9:59 AM

This revision was automatically updated to reflect the committed changes.

ealvarez@mozilla.com <ealvarez@mozilla.com> added a commit: rFIREFOXAUTOLAND73497fd0b250: Bug 1815540 - Make SVG geometry independent of pointer-events. r=longsonr….

Herald added a subscriber: tobyp. · View Herald TranscriptTue, Sep 22, 9:59 AM

ealvarez@mozilla.com <ealvarez@mozilla.com> mentioned this in rFIREFOXBETA73497fd0b250: Bug 1815540 - Make SVG geometry independent of pointer-events. r=longsonr….Thu, Sep 24, 3:59 PM

ealvarez@mozilla.com <ealvarez@mozilla.com> mentioned this in rFIREFOXRELEASE73497fd0b250: Bug 1815540 - Make SVG geometry independent of pointer-events. r=longsonr….Wed, Oct 7, 11:29 PM

Bug 1815540 - Make SVG geometry independent of pointer-events. r=longsonr,#firefox-svg-reviewers
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1384570

dom/svg/test/mochitest.toml

dom/svg/test/pointer-events.js

dom/svg/test/test_pointer-events-1a.xhtml

dom/svg/test/test_pointer-events-1b.xhtml

layout/style/nsStyleStruct.cpp

layout/svg/DisplaySVGItem.h

layout/svg/SVGGeometryFrame.cpp

layout/svg/SVGTextFrame.cpp

testing/web-platform/meta/svg/interact/scripted/rect-hittest-001.html.ini

testing/web-platform/meta/svg/interact/scripted/svg-small-big-path.html.ini

testing/web-platform/tests/svg/interact/scripted/pointer-events-fill-stroke-hittest.html

testing/web-platform/tests/svg/interact/scripted/pointer-events-getBoundingClientRect.html

Bug 1815540 - Make SVG geometry independent of pointer-events. r=longsonr,#firefox-svg-reviewersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1384570

dom/svg/test/mochitest.toml

dom/svg/test/pointer-events.js

dom/svg/test/test_pointer-events-1a.xhtml

dom/svg/test/test_pointer-events-1b.xhtml

layout/style/nsStyleStruct.cpp

layout/svg/DisplaySVGItem.h

layout/svg/SVGGeometryFrame.cpp

layout/svg/SVGTextFrame.cpp

testing/web-platform/meta/svg/interact/scripted/rect-hittest-001.html.ini

testing/web-platform/meta/svg/interact/scripted/svg-small-big-path.html.ini

testing/web-platform/tests/svg/interact/scripted/pointer-events-fill-stroke-hittest.html

testing/web-platform/tests/svg/interact/scripted/pointer-events-getBoundingClientRect.html

Bug 1815540 - Make SVG geometry independent of pointer-events. r=longsonr,#firefox-svg-reviewers
ClosedPublic
Actions

Revision Contents
Changeset List