From 4f31a96b1c04926bad877d320f4a960f9ec86fd3 Mon Sep 17 00:00:00 2001
From: Alain Mebsout <alain.mebsout@functori.com>
Date: Tue, 5 Apr 2022 15:25:44 +0200
Subject: [PATCH] Proto: Deserialize lazy exprs of tx rollup operations in
 precheck

---
 src/proto_alpha/lib_protocol/apply.ml | 28 ++++++++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

diff --git a/src/proto_alpha/lib_protocol/apply.ml b/src/proto_alpha/lib_protocol/apply.ml
index 04159696ab52..9f828cd7c48b 100644
--- a/src/proto_alpha/lib_protocol/apply.ml
+++ b/src/proto_alpha/lib_protocol/apply.ml
@@ -1891,9 +1891,17 @@ let precheck_manager_contents (type kind) ctxt (op : kind Kind.manager contents)
         Tx_rollup_errors.Message_size_exceeds_limit
       >>=? fun () -> return ctxt
   | Tx_rollup_commit _ | Tx_rollup_return_bond _
-  | Tx_rollup_finalize_commitment _ | Tx_rollup_remove_commitment _
-  | Transfer_ticket _ ->
+  | Tx_rollup_finalize_commitment _ | Tx_rollup_remove_commitment _ ->
       assert_tx_rollup_feature_enabled ctxt >>=? fun () -> return ctxt
+  | Transfer_ticket {contents; ty; _} ->
+      assert_tx_rollup_feature_enabled ctxt >>=? fun () ->
+      Lwt.return
+      @@ record_trace Gas_quota_exceeded_init_deserialize
+      @@ (* See comment in the Transaction branch *)
+      ( Script.force_decode_in_context ~consume_deserialization_gas ctxt contents
+      >>? fun (_contents, ctxt) ->
+        Script.force_decode_in_context ~consume_deserialization_gas ctxt ty
+        >|? fun (_ty, ctxt) -> ctxt )
   | Tx_rollup_dispatch_tickets {tickets_info; message_result_path; _} ->
       assert_tx_rollup_feature_enabled ctxt >>=? fun () ->
       let Constants.
@@ -1917,7 +1925,21 @@ let precheck_manager_contents (type kind) ctxt (op : kind Kind.manager contents)
         Compare.List_length_with.(
           tickets_info > tx_rollup_max_withdrawals_per_batch)
         Tx_rollup_errors.Too_many_withdrawals
-      >>?= fun () -> return ctxt
+      >>?= fun () ->
+      record_trace Gas_quota_exceeded_init_deserialize
+      @@ (* See comment in the Transaction branch *)
+      List.fold_left_e
+        (fun ctxt Tx_rollup_reveal.{contents; ty; _} ->
+          Script.force_decode_in_context
+            ~consume_deserialization_gas
+            ctxt
+            contents
+          >>? fun (_contents, ctxt) ->
+          Script.force_decode_in_context ~consume_deserialization_gas ctxt ty
+          >|? fun (_ty, ctxt) -> ctxt)
+        ctxt
+        tickets_info
+      >>?= fun ctxt -> return ctxt
   | Tx_rollup_rejection
       {message_path; message_result_path; previous_message_result_path; _} ->
       assert_tx_rollup_feature_enabled ctxt >>=? fun () ->
-- 
GitLab