From f5bb170ba69207f114e427f31afa4c90bd44ad50 Mon Sep 17 00:00:00 2001 From: Ilias Garnier Date: Thu, 30 Sep 2021 15:59:03 +0200 Subject: [PATCH] proto_{alpha,011}: reduce script_typed_ir_size flakiness --- .../lib_protocol/test/test_script_typed_ir_size.ml | 14 ++++++++++++-- .../lib_protocol/test/test_script_typed_ir_size.ml | 14 ++++++++++++-- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/src/proto_011_PtHangzH/lib_protocol/test/test_script_typed_ir_size.ml b/src/proto_011_PtHangzH/lib_protocol/test/test_script_typed_ir_size.ml index 31513054d5fa..c9c8f2626602 100644 --- a/src/proto_011_PtHangzH/lib_protocol/test/test_script_typed_ir_size.ml +++ b/src/proto_011_PtHangzH/lib_protocol/test/test_script_typed_ir_size.ml @@ -352,7 +352,12 @@ module Tests = struct | v -> check_good_approximation "value_size" - 3 + (* Used to be 3 but leads to flaky tests. Revert when + determinism is restored and the protocol is more precise + about value sizes. + FIXME: https://gitlab.com/tezos/tezos/-/issues/1784 + FIXME: https://gitlab.com/tezos/tezos/-/issues/1834 *) + 10 (Printf.sprintf "value #%d `%s' of type `%s'" i @@ -364,10 +369,15 @@ module Tests = struct | _ | (exception _) -> return () let check_value_size_stats () = + (* Stddev set to 0.5, used to be 0.2 but leads to flaky tests. + Revert when determinism is restored and the protocol is more + precise about value sizes. + FIXME: https://gitlab.com/tezos/tezos/-/issues/1784 + FIXME: https://gitlab.com/tezos/tezos/-/issues/1834 *) check_stats "value_size" ~expected_mean:(1., 0.2) - ~expected_stddev:(0., 0.2) + ~expected_stddev:(0., 0.5) ~expected_ratios:(1., 3.) let lambda_size nsamples = diff --git a/src/proto_alpha/lib_protocol/test/test_script_typed_ir_size.ml b/src/proto_alpha/lib_protocol/test/test_script_typed_ir_size.ml index 33cb593eaa41..16f9b0439671 100644 --- a/src/proto_alpha/lib_protocol/test/test_script_typed_ir_size.ml +++ b/src/proto_alpha/lib_protocol/test/test_script_typed_ir_size.ml @@ -353,7 +353,12 @@ module Tests = struct | v -> check_good_approximation "value_size" - 3 + (* Used to be 3 but leads to flaky tests. Revert when + determinism is restored and the protocol is more precise + about value sizes. + FIXME: https://gitlab.com/tezos/tezos/-/issues/1784 + FIXME: https://gitlab.com/tezos/tezos/-/issues/1834 *) + 10 (Printf.sprintf "value #%d `%s' of type `%s'" i @@ -365,10 +370,15 @@ module Tests = struct | _ | (exception _) -> return () let check_value_size_stats () = + (* Stddev set to 0.5, used to be 0.2 but leads to flaky tests. + Revert when determinism is restored and the protocol is more + precise about value sizes. + FIXME: https://gitlab.com/tezos/tezos/-/issues/1784 + FIXME: https://gitlab.com/tezos/tezos/-/issues/1834 *) check_stats "value_size" ~expected_mean:(1., 0.2) - ~expected_stddev:(0., 0.25) + ~expected_stddev:(0., 0.5) ~expected_ratios:(1., 3.) let lambda_size nsamples = -- GitLab